summaryrefslogtreecommitdiff
path: root/plugins
diff options
context:
space:
mode:
authorCyrille Bagard <nocbos@gmail.com>2018-06-28 16:57:12 (GMT)
committerCyrille Bagard <nocbos@gmail.com>2018-06-28 16:57:12 (GMT)
commita180a6b30713f38f58a9adc89d775fd142f19629 (patch)
tree5c499f55df7a10862236f0fc92d45c0c8ac62c70 /plugins
parent3612ad254e8ef4a4ffed735b7f0e0fcb16b86bb5 (diff)
Limited ELF section name lengths as it is done for segment names.
Diffstat (limited to 'plugins')
-rw-r--r--plugins/elf/format.c4
-rw-r--r--plugins/elf/strings.c2
2 files changed, 2 insertions, 4 deletions
diff --git a/plugins/elf/format.c b/plugins/elf/format.c
index 8c0f0fc..d41ba00 100644
--- a/plugins/elf/format.c
+++ b/plugins/elf/format.c
@@ -666,9 +666,9 @@ static void g_elf_format_refine_portions(GElfFormat *format)
else name = NULL;
if (name != NULL)
- sprintf(desc, "%s \"%s\"", _("Section"), name);
+ snprintf(desc, MAX_PORTION_DESC, "%s \"%s\"", _("Section"), name);
else
- sprintf(desc, "%s ???", _("Section"));
+ snprintf(desc, MAX_PORTION_DESC, "%s ???", _("Section"));
g_binary_portion_set_desc(new, desc);
diff --git a/plugins/elf/strings.c b/plugins/elf/strings.c
index cc40db1..a14b389 100644
--- a/plugins/elf/strings.c
+++ b/plugins/elf/strings.c
@@ -142,8 +142,6 @@ bool find_all_elf_strings(GElfFormat *format, wgroup_id_t gid, GtkStatusStack *s
if (!got_string)
{
- assert(false);
-
max = ELF_HDR(format, format->header, e_phoff)
+ ELF_HDR(format, format->header, e_phnum) * ELF_SIZEOF_PHDR(format);