1 files changed, 82 insertions, 19 deletions
diff --git a/plugins/arm/v7/opdefs/ror_A88149.d b/plugins/arm/v7/opdefs/ror_A88149.d
index 7e061c6..0717a95 100644
--- a/plugins/arm/v7/opdefs/ror_A88149.d
+++ b/plugins/arm/v7/opdefs/ror_A88149.d
@@ -2,7 +2,7 @@
 /* Chrysalide - Outil d'analyse de fichiers binaires
  * ##FILE## - traduction d'instructions ARMv7
  *
- * Copyright (C) 2015 Cyrille Bagard
+ * Copyright (C) 2017 Cyrille Bagard
  *
  *  This file is part of Chrysalide.
  *
@@ -23,26 +23,55 @@
 
 @title ROR (immediate)
 
-@desc Rotate Right (immediate) provides the value of the contents of a register rotated by a constant value. The bits that are rotated off the right end are inserted into the vacated bit positions on the left. It can optionally update the condition flags based on the result.
+@id 148
+
+@desc {
+
+	Rotate Right (immediate) provides the value of the contents of a register rotated by a constant value. The bits that are rotated off the right end are inserted into the vacated bit positions on the left. It can optionally update the condition flags based on the result.
+
+}
 
 @encoding (T1) {
 
 	@word 1 1 1 0 1 0 1 0 0 1 0 S(1) 1 1 1 1 0 imm3(3) Rd(4) imm2(2) 1 1 Rm(4)
 
-	@syntax <reg_D> <reg_M> <shift_imm>
+	@syntax {
+
+		@assert {
+
+			S == 0
+
+		}
+
+		@conv {
 
-	@conv {
+			reg_D = Register(Rd)
+			reg_M = Register(Rm)
+			shift_n = DecodeImmShiftAmount('11', imm3:imm2)
 
-		reg_D = Register(Rd)
-		reg_M = Register(Rm)
-		setflags = (S == '1')
-		shift_imm = DecodeImmShift('11', imm3:imm2)
+		}
+
+		@asm ror ?reg_D reg_M shift_n
 
 	}
 
-	@rules {
+	@syntax {
+
+		@assert {
+
+			S == 1
+
+		}
 
-		if (setflags); chk_call ExtendKeyword("s")
+		@conv {
+
+			reg_D = Register(Rd)
+			reg_M = Register(Rm)
+			shift_n = DecodeImmShiftAmount('11', imm3:imm2)
+
+		}
+
+		@asm rors ?reg_D reg_M shift_n
 
 	}
 
@@ -52,21 +81,55 @@
 
 	@word cond(4) 0 0 0 1 1 0 1 S(1) 0 0 0 0 Rd(4) imm5(5) 1 1 0 Rm(4)
 
-	@syntax <reg_D> <reg_M> <shift_imm>
+	@syntax {
+
+		@assert {
 
-	@conv {
+			S == 0
 
-		reg_D = Register(Rd)
-		reg_M = Register(Rm)
-		setflags = (S == '1')
-		shift_imm = DecodeImmShift('11', imm5)
+		}
+
+		@conv {
+
+			reg_D = Register(Rd)
+			reg_M = Register(Rm)
+			shift_n = DecodeImmShiftAmount('11', imm5)
+
+		}
+
+		@asm ror ?reg_D reg_M shift_n
+
+		@rules {
+
+			check g_arm_instruction_set_cond(cond)
+
+		}
 
 	}
 
-	@rules {
+	@syntax {
+
+		@assert {
+
+			S == 1
+
+		}
+
+		@conv {
+
+			reg_D = Register(Rd)
+			reg_M = Register(Rm)
+			shift_n = DecodeImmShiftAmount('11', imm5)
+
+		}
+
+		@asm rors ?reg_D reg_M shift_n
+
+		@rules {
+
+			check g_arm_instruction_set_cond(cond)
 
-		if (setflags); chk_call ExtendKeyword("s")
-		chk_call StoreCondition(cond)
+		}
 
 	}